Skip to content

Use standard error message for stack limit in serialize() #16225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use standard error message for stack limit in serialize() #16225

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 4, 2024

With GH-16204 merged, we can use the standard error message for the recently-merged GH-16159.

@nielsdos
Use standard error message for stack limit in serialize()
22aa26d 
With phpGH-16204 merged, we can use the standard error message for the
recently-merged phpGH-16159.
@nielsdos nielsdos requested a review from arnaud-lb October 4, 2024 17:27
@nielsdos nielsdos requested a review from bukka as a code owner October 4, 2024 17:27
arnaud-lb
arnaud-lb approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nielsdos nielsdos closed this in 612a6ad Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @arnaud-lb